Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CC0 license update #118

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Jan 24, 2024

The CC0 license can just be linked from the header and not included in the repo, per legal. Renaming the MIT license file as a result.

@adam-alchemy
Copy link
Contributor

I think it might confuse readers if there's a file that's just called "LICENSE" in the root folder that contains the MIT license, but some of the contents within the repo are under GPL-3. Would it make sense to keep the filename as "LICENSE-MIT" to call out that this is a specific one, not comprehensive of all contents?

@jaypaik
Copy link
Collaborator Author

jaypaik commented Jan 24, 2024

I think it might confuse readers if there's a file that's just called "LICENSE" in the root folder that contains the MIT license, but some of the contents within the repo are under GPL-3. Would it make sense to keep the filename as "LICENSE-MIT" to call out that this is a specific one, not comprehensive of all contents?

Yeah I can see that. Typically the extensions are only used when there are multiple licenses with the same name in the same folder. In this case we have COPYING (GPLv3) and LICENSE (MIT), and the README lists the licenses at the top and we dive into the coverage at the bottom. We should be good here, and this was the original recommendation from legal, but let me know if you feel strongly (I don't).

Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, that makes sense. Don't feel strongly here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jaypaik jaypaik merged commit 6e7ee3f into audit-2023-11-20 Jan 24, 2024
3 checks passed
@jaypaik jaypaik deleted the 01-24-chore_CC0_license_update branch January 24, 2024 22:32
jaypaik added a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants